-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The “continue” button should not disappear after you click it #255
Comments
Hi, @ara4n I would like to work on this issue, so can you please assign me this issue. |
is this issue still open? |
@ara4n It's unclear what your ideal layout and flow is here. I'm assuming you want the "Continue in your browser" button to still be available. Instead of only having the option to download the app from the app store. Maybe this mock-up matches what you're thinking? As a note, this flow is broken in a different way nowadays to go straight from "Continue" to https://app.element.io (see #262 (comment)) |
Synced out of band with @ara4n, here is the ideal/expected UI here:
|
Potential solutionsPre-packaged solutionsThere are a few out of the box solutions from Firebase and branch.io but they require using their SDK's and we give up some privacy: It's also not clear to me how their first time user-experience is for people clicking a universal link. When you first install the app and click a universal link, what happens? Does it open mobile Safari with the smart app banner to "Open" in the app at the top like everyone else? That's the sucky part. Universal links
To accomplish this, I was thinking that on
❌ But I discovered that universal links suck for what we want to do. Universal links are just normal
Note: After you have allowed the "Open in Element app" by pressing "Open" the first time in the Safari banner, subsequent If someone starts without the app installed, we could get the same banner experience by adding a "Smart App Banner", where it prompts the user to go view the Element iOS app on the app store, see https://developer.apple.com/documentation/webkit/promoting_apps_with_smart_app_banners - we should probably do this in any case because people can stumble upon But all of this isn't very viable because we want to avoid going to Element web on mobile altogether. Someone can easily just dismiss the banners or ignore them and try to use mobile Element web which will be a bad time. Even when the user has the app installed, they can ignore the "Open" banner. If I was an iOS user, I kinda like this behavior because I don't like when websites force me to install apps in order to view content. We should really look into optimizing the main views you would see in mobile Element web coming from Get what we want, custom URL schemeI think we could get what we want if we used a custom URL scheme and registered to handle that in the Element iOS app. The scheme could be When the app is not installed and the user tries to open the app via the custom URL scheme, it will simply throw a "Safari cannot open the page because the address is invalid" toast. We get a preview to see how this could look like because FluffyChat does this:
When the Element iOS app is installed, the custom URL scheme, simply opens the app seamlessly. Update: From a call with @stefanceriu, he mentioned that custom URL schemes ask every time which app they should be opened with which adds a different type of friction. But as @ara4n originally points out in this issue, we should also keep the "Continue" button with the custom URL scheme link on screen so the user can retry the Block Element web access with the
|
So EW specifically doesn't forward you to the mobile_guide when you're hitting a permalink, iirc this is important for 3pid invites which require EW Related element-hq/element-web#7378 |
Thanks for the details @t3chguy. I think we can workaround to still allow "verifying a 3pid (but after we've loaded the config)" and load the mobile guide otherwise. Based on element-hq/element-web#7378 saying redirects stopped the deep links from working, I think we're going to have to load the mobile guide at various URL's instead of redirecting there. |
Describe the bug
If you follow a permalink, the continue to open in element button disappears after being clicked. This is very confusing if you want to click it again
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The continue permalink opens in Element; but the continue button remains present on the
matrix.to
tab rather than vanishing.This allows for people to try the link again after installing the native app.
Screenshots
Come back, blue button!
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: