Adding basic support for flexible cards #39
Conversation
matheusgomes28
force-pushed
the
add-card-support
branch
from
59df586 to
446f776
Compare
matheusgomes28
force-pushed
the
add-card-support
branch
from
446f776 to
ced30a3
Compare
| if image_location == "" { | ||
| return fmt.Errorf("cannot have image") | ||
| } | ||
| image_stat, err := os.Stat(image_location) | ||
| if errors.Is(err, os.ErrNotExist) { | ||
| return fmt.Errorf("file does not exist: %s", image_location) | ||
| } | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if image_stat.IsDir() { | ||
| return fmt.Errorf("given path is a directory: %s", image_location) | ||
| } | ||
|
|
||
| // Load the schema | ||
| // TODO : probably pass the schema data instead | ||
| if json_data == "" { | ||
| return fmt.Errorf("cannot have empty data") | ||
| } | ||
|
|
||
| if schema_name == "" { | ||
| return fmt.Errorf("cannot have an empty schema name") | ||
| } | ||
|
|
||
| _, err = validateJson(json_data, schema_name) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
All this validation should happen in the service. The database should only persist the valid data to the database. Separating business and infrastructure (i.e. database operations) logic is key to having a clean architecture.
There was a problem hiding this comment.
I need to continue working on this. I did some poc work during a stream and forgot to finish it off!
| <<<<<<< HEAD | ||
| GetPosts(int, int) ([]common.Post, error) | ||
| ======= | ||
|
|
||
| // Post related stuff | ||
| GetPosts() ([]common.Post, error) | ||
| >>>>>>> 446f776 (Adding basic support for flexible cards) |
| } | ||
|
|
||
| // Validate the json | ||
| validateJson(card.JsonData, card.SchemaName) |
There was a problem hiding this comment.
Is there a reason why you need to validate the data after loading it from the database? If the data was validated when storing it to the database then validating it again should be obsolete, unless the configured schema has changed. And by this point the data in the database is broken and should be deleted anyways.
| func validateJson(json_data string, schema_name string) (bool, error) { | ||
| schema_data, err := os.ReadFile(filepath.Join("schemas", fmt.Sprintf("%s.json", schema_name))) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| schemaLoader := gojsonschema.NewBytesLoader(schema_data) | ||
| documentLoader := gojsonschema.NewStringLoader(json_data) | ||
| result, err := gojsonschema.Validate(schemaLoader, documentLoader) | ||
| if err != nil { | ||
| return false, fmt.Errorf("could not read json_data: %v", err) | ||
| } | ||
| if !result.Valid() { | ||
| json_err := fmt.Errorf("invalid card json: ") | ||
| for _, e := range result.Errors() { | ||
| json_err = fmt.Errorf("%v %s", json_err, e) | ||
| } | ||
| return false, json_err | ||
| } | ||
|
|
||
| return true, nil | ||
| } |
There was a problem hiding this comment.
IMO this should be in a separate package for handling cards and the related business logic.
TODO desc