Added some notes and minor refactor computed tables #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warning:
mpq/mpq_sdl_rwops.cpp:82:25: warning: comparison of unsigned expression in '< 0' is always false [-Wtype-limits]
82 | if (newPosition < 0) {
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Seems to be needed for SDL2_image https://github.com/diasurgical/devilutionX/actions/runs/7781145615/job/21215031007
This reverts commit ff57b6b.
It's not relevant to flatpak anyway
matheusgomes28
commented
Feb 7, 2024
Source/inv.cpp
Outdated
| @@ -325,27 +326,158 @@ int FindTargetSlotUnderItemCursor(Point cursorPosition, Size itemSize) | |||
| return NUM_XY_SLOTS; | |||
| } | |||
|
|
|||
| static constexpr std::array<item_equip_type, 55> item_loc_table { | |||
There was a problem hiding this comment.
Maybe we don't need this because this code is only running every now and then
Bumps [lukka/run-vcpkg](https://github.com/lukka/run-vcpkg) from 11.4 to 11.5. - [Release notes](https://github.com/lukka/run-vcpkg/releases) - [Commits](lukka/run-vcpkg@v11.4...v11.5) --- updated-dependencies: - dependency-name: lukka/run-vcpkg dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.3 to 2. - [Release notes](https://github.com/microsoft/setup-msbuild/releases) - [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md) - [Commits](microsoft/setup-msbuild@v1.3...v2) --- updated-dependencies: - dependency-name: microsoft/setup-msbuild dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Change `lastFpsUpdateInMs` to `uint32_t` to harmonize the logic in `DrawFPS()` with `SDL_GetTicks()`. Fixes compiler warnings.
Remove unused function parameter
Removed unused function parameter
…ctor-check-inventory-paste-func
|
I think you can close this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.