-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements list will discourage people from using the rester #61
Comments
Fair enough. I think we should just train our own tokenizer and get rid of CDE though.
On Mon, Nov 25, 2019 at 8:14 PM, Alex Dunn <[email protected]> wrote:
If we want people to use the awesome API we have made, the rester needs to be easily installed. If you don't have 3.6, its not easy to install.
I get that the extra requirements are for the non-rester parts of the code. But if they make installing the feature that the most people will be interested in (likely the rester to access the API), then they are not serving much good here. Maybe we could relocate them to another package, or have mat scholar's rester be its own package, matscholar-rest or something like that, with a minimal set of requirements and which we can easily put on pipit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [#61?email_source=notifications&email_token=ACFODYP6UQFBI2BBAY4H5KDQVSPA5A5CNFSM4JRSFR5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H37437A] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/ACFODYJDTS7FDS4ZJM754XDQVSPA5ANCNFSM4JRSFR5A] .
|
+1 for this, I'll eventually be getting around to adding MatScholar integration on MP, and the requirements are definitely heavy (CDE aside, there's the direct git install package, gensim, etc.) |
That too. |
@jdagdelen we can discuss this on the call today if there is time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we want people to use the awesome API we have made, the rester needs to be easily installed. If you don't have 3.6, its not easy to install.
I get that the extra requirements are for the non-rester parts of the code. But if they make installing the feature that the most people will be interested in (likely the rester to access the API) more difficult, then they are not serving much good here. Maybe we could relocate them to another package, or have mat scholar's rester be its own package,
matscholar-rest
or something like that, with a minimal set of requirements and which we can easily put on pypi.The text was updated successfully, but these errors were encountered: