Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements list will discourage people from using the rester #61

Open
ardunn opened this issue Nov 26, 2019 · 4 comments
Open

requirements list will discourage people from using the rester #61

ardunn opened this issue Nov 26, 2019 · 4 comments

Comments

@ardunn
Copy link
Contributor

ardunn commented Nov 26, 2019

If we want people to use the awesome API we have made, the rester needs to be easily installed. If you don't have 3.6, its not easy to install.

I get that the extra requirements are for the non-rester parts of the code. But if they make installing the feature that the most people will be interested in (likely the rester to access the API) more difficult, then they are not serving much good here. Maybe we could relocate them to another package, or have mat scholar's rester be its own package, matscholar-rest or something like that, with a minimal set of requirements and which we can easily put on pypi.

@jdagdelen
Copy link
Contributor

jdagdelen commented Nov 26, 2019 via email

@mkhorton
Copy link

+1 for this, I'll eventually be getting around to adding MatScholar integration on MP, and the requirements are definitely heavy (CDE aside, there's the direct git install package, gensim, etc.)

@ardunn
Copy link
Contributor Author

ardunn commented Nov 26, 2019

That too.

@ardunn
Copy link
Contributor Author

ardunn commented Nov 26, 2019

@jdagdelen we can discuss this on the call today if there is time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants