Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested minor renames #25

Open
computron opened this issue Jun 1, 2019 · 0 comments
Open

suggested minor renames #25

computron opened this issue Jun 1, 2019 · 0 comments

Comments

@computron
Copy link
Contributor

I suggest renaming all the search functions in Rester as: search_<<SOMETHING>>

e.g.:

  • materials_search --> search_materials
  • materials_search_ents --> search_materials_by_entities
  • search_ents --> search_entities
  • get_summary --> search_entities_summary
  • search_text_with_ents --> search_documents

Note that I think materials_search and materails_search_ents should be combined into one function anyway (search_materials handles all cases) - just like how there is only one function to search the documents that combines both text search and entity search.

Also:

  • close_words --> get_close_words

  • get_journals --> get_close_journals

  • get_similar_materials --> get_close_materials

  • get_ner_tags --> perform_ner (since you are not getting anything from the database)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant