increase button spacing from 0 to 5 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A design with a gap of 5px doesn't looks nice for me. You're are hardcoding something which can be handle by a GTK theme. |
|
Keep in mind that you increase the whole window size with your setting. |
|
you are probably right, I tested it on some more mate themes, and even with 2px it does not look good. Note that in gnome-calculator it is hard coded to 4px, but they only have one theme to worry about, so it is reasonable in that case. Thus, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it does look a lot nicer (fixes #54).
Before:
After:
