-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ribbon not applied to API 26 adaptive-icons #23
Comments
Any timeline on this? I use a vector for my foreground adaptive icon layer and would like to be able to apply the ribbon to it. |
Unlikely to be soon as I've fixed it for our use-case, but once I get some free time or open-source contribution time at work, this is the top of my priority list. |
+1 - @mensly can we see your workaround ? |
Well as for a workaround, adaptive icons use a foreground and a background for the launcher icon, what could be done is:
ps. thank you for this lib. saved me a lot of effort for non-oreo devices. |
This library is super cool but unfortunately we are not able to use it since this does not work for oreo and above devices. Any timeline on when we can have this working for adaptive icons? |
Currently, no visible changes will be made to the icons when using this plugin with the default template project in Canary Android Studio 3.0 and run on a device running the Android 8 Beta. This is due to changes in how icons are specified to allow vector formats and masked layers.
A few approaches I am considering in order to fix this if I have the time would be to (optionally) trash the
mipmap-anydpi-v26
directory when applying a ribbon or draw a ribbon in a more central position when applying toic_launcher_foreground
. It should also be possible to apply colour filters (iegrayScaleFilter
) to vector assets by modifyingfillColor
andstrokeColor
in the xml attributes.See: https://developer.android.com/preview/features/adaptive-icons.html
The text was updated successfully, but these errors were encountered: