Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check for USB permissions before running adb commands #4

Open
pdsouza opened this issue Apr 17, 2017 · 4 comments
Open

Need to check for USB permissions before running adb commands #4

pdsouza opened this issue Apr 17, 2017 · 4 comments
Assignees

Comments

@pdsouza
Copy link
Member

pdsouza commented Apr 17, 2017

Right now, the script only shows the udev permissions script if fastboot shows no permissions. But it's possible that adb itself doesn't have the right USB permissions too, so we need to show the udev permissions script in this case too.

We can check for this right at the beginning and prompt the user to run the wget script,

@pdsouza pdsouza self-assigned this Apr 17, 2017
@pdsouza
Copy link
Member Author

pdsouza commented May 10, 2017

Update: this will be fixed with the new Go installers.

@utzcoz
Copy link
Member

utzcoz commented May 15, 2019

@pdsouza , This issue has been fixed by your old commit, maybe it can be closed.

@pdsouza
Copy link
Member Author

pdsouza commented May 22, 2019

@utzcoz I think the installers only show the script if fastboot shows a permission error but we need to check adb too since we use adb reboot bootloader.

I actually have fixed this in the new go installers on branch go-installers which fetch the releases directly from GitHub. Since we are shipping the update zips directly for users to install with TWRP I haven't prioritized them very much though. I think I can extend them to flash the images directly like these scripts too.

@utzcoz
Copy link
Member

utzcoz commented May 23, 2019

Ok, I got it. Hope go-installer can be merged to master quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants