Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add CSV-Analyzer #2205

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add CSV-Analyzer #2205

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 22, 2024

It can plot value vs line number/ time value (for only known log formats), and value vs another value scatter graphs.

Log: add software name--CSV-Analyzer
CSV-Analyzer

@kamiyadm
Copy link
Contributor

patch应用失败了

@wjyrich
Copy link
Contributor Author

wjyrich commented May 29, 2024

/check build

@wjyrich
Copy link
Contributor Author

wjyrich commented May 29, 2024

/check build

@wjyrich
Copy link
Contributor Author

wjyrich commented May 29, 2024

/check build

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 29, 2024

Deepin Obs Bot
Starting find obs webhook event and retrigger!

It can plot value vs line number/ time value (for only known log formats), and value vs another value scatter graphs.

Log: add software name--CSV-Analyzer
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch中,删除和插入的行顺序可能需要调整,以保持代码的一致性和可读性。
  • CsvAnalyzer.pro文件中,else块中的注释应该放在else之后,而不是之前。
  • target.path的赋值应该在else块中,以确保在所有平台上都使用正确的路径。
  • desktop.filesdesktop.path的赋值应该在desktop.files之前,以确保顺序正确。
  • icons.filesicons.path的赋值应该在icons.files之前,以确保顺序正确。
  • 缺少对新增代码行的解释注释,应该说明为什么需要这些更改。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 6daffca into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants