Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer_Size in ILI9341_Draw_Colour_Burst() should be fixed #8

Open
bluenlive opened this issue Nov 20, 2019 · 3 comments
Open

Buffer_Size in ILI9341_Draw_Colour_Burst() should be fixed #8

bluenlive opened this issue Nov 20, 2019 · 3 comments

Comments

@bluenlive
Copy link

Thank you for your great work!

BTW, I think following line should be fixed
Buffer_Size = Size;
to
Buffer_Size = Size * 2;

It also causes that ILI9341_Draw_Char() works not properly.
When Size > 1 drawn character seems not clean.

@drzacek
Copy link

drzacek commented Oct 1, 2021

Changing the buffer_size in ILI9341_Draw_Colour_Burst() to Size * 2 was the solution!

I was getting weird effects when trying to use vertical lines, they changed color mid way.

@ChrisPVille
Copy link

ChrisPVille commented Dec 1, 2021

This is most definitely a bug causing stack corruption when the requested Size < BURST_MAX_SIZE and odd (look at the for loop immediately after). The fix above worked for me as well.

@FabienG42
Copy link

Indeed !
I have experienced some bad divison by 0 with this ILI9341_Draw_Colour_Burst()
if you call it with size=0 then Buffer_Size is 0
At this line :
uint32_t Sending_in_Block = Sending_Size/Buffer_Size; //DIVISION by 0 possible
Major failure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants