Specifying a default for the zoned property breaks delegated datasets

[bdha]

When delegating a dataset into a non-global zone, certain properties cannot be modified. zoned is one of those, as it's managed by the global zone exclusively.

The zfs cookbook sets a default of zoned: off, which causes convergence to fail when executed inside a zone:

https://github.com/marthag8/zfs/blob/master/resources/default.rb#L5

    Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '1'
    ---- Begin output of zfs set zoned=off zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data ----
    STDOUT:
    STDERR: cannot set property for 'zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data': permission denied
    ---- End output of zfs set zoned=off zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data ----
    Ran zfs set zoned=off zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data returned 1

Attempting to modify the property at all is disallowed (and causes Chef to fail):

zfs set zoned=on zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data
cannot set property for 'zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data': permission denied

Is there a specific reason a default is defined?

Simply setting default to nil doesn't solve the problem:

    Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '1'
    ---- Begin output of zfs set zoned= zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data ----
    STDOUT:
    STDERR: cannot set property for 'zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data': 'zoned' must be one of 'on | off'
    ---- End output of zfs set zoned= zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data ----
    Ran zfs set zoned= zones/b0ea2503-c8c5-68d4-a6a3-d55d0f526faa/data returned 1

[bdha]

Ah, I see an exception got added to .6 for FreeBSD support. Cool!

This gets a bit weird, though... in most cases, the best way to determine I'm in a zone would be to use

virtualization[:system] == "zone"

but I'm wandering around the bleeding edge and using Joyent's new LX brand (with delegated ZFS datasets, no less!), so the best ohai entry to use is

kernel[:version] == "BrandZ virtual linux

I'm going to hack up something in the provider to account for this... totally open to suggestions on how to make it not suck, though!