Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate Env Vars to configure file size limits for search and add docs #1058

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

RaynorChavez
Copy link
Member

@RaynorChavez RaynorChavez commented Dec 3, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    We only define MARQO_MAX_VIDEO_AUDIO_SEARCH_FILE_SIZE

  • What is the new behavior (if this is a feature change)?
    We split the above into

  • MARQO_MAX_SEARCH_VIDEO_AUDIO_FILE_SIZE
  • MARQO_MAX_ADD_DOCS_VIDEO_AUDIO_FILE_SIZE
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaynorChavez RaynorChavez merged commit 5660996 into mainline Dec 3, 2024
9 checks passed
@RaynorChavez RaynorChavez deleted the feature/split_file_size_env branch December 3, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants