Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal grove dependencies #5

Open
grtjn opened this issue Sep 29, 2020 · 0 comments
Open

Remove internal grove dependencies #5

grtjn opened this issue Sep 29, 2020 · 0 comments

Comments

@grtjn
Copy link

grtjn commented Sep 29, 2020

Are these dependencies actually used?

    "@marklogic-community/grove-search-redux": "github:marklogic-community/grove-search-redux#3-do-not-duplicate-filters",
    "@marklogic-community/grove-user-redux": "git+https://github.com/dalaidunc/grove-user-redux.git#d3f25f9b486d1e7ef36bad7add3fc83a57d8ec48",
    "grove-core-react-redux-containers": "git+https://project.marklogic.com/repo/scm/~pmcelwee/grove-core-react-redux-containers.git#1.0.0-rc.1",

We'd like to clean up these repos. We have folded all inside grove-react-ui. Might be useful to consider doing the same, and remove all of the grove dependencies completely (they don't really add value)..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant