mark2 is not using console colors

[TomLewis]

Everything is black and white in the live console for Mark2, how can I get colors to show for colored items in the console? Like player names etc.

[RhvsW]

Terminal colors are stripped by default, see: https://github.com/gsand/mark2/blob/master/mk2/resources/mark2.default.properties#L102

[TomLewis]

How do I disable it to get a colored console again?

[gsand]

I honestly don't remember. I've been kinda busy lately and haven't had time to do mark2 updates.
😢

[TomLewis]

I would very much appreciate getting colours in the console, if you have some time @gsand could you please look into how I can get colors working in the console. Thank you.

[TomLewis]

Bump.
Please can we get proper colors showing in terminal, this plane white is impossible to read.

[danthedaniel]

You can just comment on that line in the default properties, right?

[RhvsW]

mark2 doesn't parse the colors at all.

[TomLewis]

Bump; can we implement colors; this bash script is pre-made and needs to be merged somehow into Makr2, this fella is the one that makes the timing reports website and paperspigot.
https://aikar.co/2015/07/28/bash-colors-for-minecraft-shell-scripts/

[KasperFranz]

Has anyone been able to figure this out?

I can see from another issue that @Sir-Will got it working on a previous issue ( over a year ago) (the issue wasn't about missing colors but more about a colour not showing correct #35)

[Sir-Will]

I have this issue too, on few servers it shows colors on the others not, although they have the same plugins and version.

[KasperFranz]

hmm is it related to the os?

[Sir-Will]

@KasperFranz the servers are on the same box, so same ubuntu version.

[KasperFranz]

oh that is weird then o.0

and guessing nearly same config?

[Sir-Will]

Yea, already looked for a difference, couldn't find one.

[KasperFranz]

that is weird, I have even tried with 1.8 and 1.9 servers which is also scrapping the colors (planning on using it for a 1.7 server)

[Column01]

Did some digging and ANSI codes do work, but all player input that is sent to the console has color codes stripped before we receive it so we can't format it after the fact. As for the unsupported terminal flag, I believe that is mandatory as it will crash the server without it in some instances.

You can test it by sending a color-coded message using the say command from the console:

I looked at what gets received when a line is printed on the console, and it has all the formatting stripped which would be why it doesn't get colorized. I'm not entirely sure how to set it up where formatting is passed on to mark2.

Regardless of this, I made some changes to the code to allow the use of color codes from the console sender in the form of ampersands (&) as long as the command is a say command. This should hopefully prevent errors but honestly not sure we even need to check that its a say command as I've never seen a command use &<number> in it

See commit: a684890

[Column01]

Removing the unsupported terminal flag still yielded no colors so that's not related I don't think (at least on mark2's end)

[Column01]

Ok, interesting... I just tried on another server running Mohist 1.16.5 (forge-spigot similar to thermos) and the server saying something showed as colored in reply, but doing it as a player did not.

[mattboy9921]

@Column01 Thank you for the commits and research on this! Glad to see someone else poking around lol.

Now correct me if I'm wrong but is it not the case that the [Warning] and [Severe] messages should be colored? Or perhaps that is just a feature of certain consoles? I honestly rarely use anything other than Mark2, even just bare terminal so I am quite unaware if it is colored there or not.

[Column01]

Now correct me if I'm wrong but is it not the case that the [Warning] and [Severe] messages should be colored?

I've not tested running these instances bare in a terminal, might have to try that. It's been forever since I've run a server through an actual terminal and not using mark2.

[Column01]

Again, on the mohist server it appears that Unicode color-coded strings that are from the server are colored in the console:

Definitely feel like this is a spigot thing where it disables color codes in the console from players and their names, probably to allow for less confusion with color-coded warnings/errors. Speaking of which, it should be possible for mark2 to automatically color code the level info with some minor changes.

[Column01]

What do you think about this? Does it look similar to what happens for errors from a standard console? The problem with this is it will not work for multi-line errors (for example a stack trace) afaik. Also considering just highlighting the level message

[mattboy9921]

@Column01 That does look pretty much like what I've seen in other consoles (keep in mind I am in the same boat as you, mainly use Mark2 so)

[Column01]

What about highlighting just the log level? Do you think that would look better? Also fixes not highlighting a full multiline error message, but still draws attention to issues.

[mattboy9921]

I think highlighting just the log level does make sense since you said stack traces don't get highlighted correctly but I honestly prefer the whole line to be highlighted. Perhaps it is possible to add a config option?

[Column01]

I don't think a config option for something like this makes sense considering level highlighting is the default behavior for the Minecraft server console. Come to think of it, the only errors that won't get highlighted in the multiline form are those that use e.printStackTrace() instead of properly logging it (since it will be in RAW or some other level instead of a proper log level)

For example:

I suppose I'll just do full line highlighting then

[Column01]

Added the log level color changes in 15ece58

[Column01]

My suspicions were correct, proper multiline stack trace printing works as intended.

[Column01]

Moved to a discussion, this isn't an issue with mark2 and is likely the server software stripping the color data as discussed.

[TomLewis]

I cant wait to have some sort of highlighting

[Column01]

The latest mark2 has highlighting for warnings and errors