Feat 🛠️ / Refresh connection when validator is down #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janlegner
reviewed
Dec 7, 2022
client/grpc_client.rs
Outdated
| fn validator_check() -> Result<String, String> { | ||
| let sys = System::new_all(); | ||
| for process in sys.processes_by_name("solana-valid") { | ||
| if process.run_time() / 60 > DEFAULT_VALIDATOR_WARMUP_MINUTES { |
There was a problem hiding this comment.
let run_time_minutes = process.run_time() / 60
janlegner
reviewed
Dec 7, 2022
janlegner
reviewed
Dec 7, 2022
client/grpc_client.rs
Outdated
| } | ||
| .connect() | ||
| .await?; | ||
| loop { |
There was a problem hiding this comment.
Please simplify this loop. You got some unnecessary breaks/continues, ifs. Try to make it a bit more flat. If you find it difficult, move some parts of the code to a separate function.
There was a problem hiding this comment.
The loop should be:
- Wait for validator to become ready, if that takes too long, exit
- Connect
janlegner
reviewed
Dec 7, 2022
client/grpc_client.rs
Outdated
| @@ -79,6 +97,10 @@ async fn mtx_stream( | |||
| let mut response_stream = response.into_inner(); | |||
|
|
|||
| loop { | |||
| let result = validator_check(); | |||
There was a problem hiding this comment.
This seems like a job for a oneshot channel, you can then process that in the tokio::select. This way it would slow down the loop a lot. Also, the whole feature must be behind a config flag. E.g. when QUIC client is used instead of local RPC forward, this should not be checked at all.
There was a problem hiding this comment.
I made a watcher loop task that will send a shutdown message via oneshot channel when validator is offline
janlegner
reviewed
Dec 20, 2022
There was a problem hiding this comment.
- Remove all unnecessary
.clone() - The main fn 1) waits for validator to be online, 2) spawns watcher, 3) spawns grpc client.
mtx_streamhas 1 extra argument:exit_signal(?) that enables clean exit of the watcher decides so.- Add one exatra parameter to the CLI which controls whether the watcher runs (default = false)
janlegner
pushed a commit
that referenced
this pull request
May 15, 2024
* Added rust toolchain * Remove auth (#3) * Remove auth Remove need for JWT auth for internal deploy * Remove auth from server * Implement optional authentication IF you don't provide the JWT public key then the server enters into non authenticated mode. * Update domain and company name for the certs (#4) * Fixes cert validation (#6) * Add support for connecting to multiple servers (#7) Adds support for connecting to multiple servers. * Fix metrics per host (#9) * Add support for connecting to multiple servers Adds support for connecting to multiple servers. * Added metrics per server Adds source tag to metrics so metrics are reported per server. * Formatting * Added basic health check (#10) * Added basic health check * Update server/rpc_server.rs Co-authored-by: Kirill Fomichev <[email protected]> --------- Co-authored-by: Kirill Fomichev <[email protected]> * Add authentication identifier (#11) * Fix reporting name * Get auth information from header Get auth information from header so we can populate in metrics. * Update server/rpc_server.rs Co-authored-by: Kirill Fomichev <[email protected]> * Update server/rpc_server.rs Co-authored-by: Kirill Fomichev <[email protected]> --------- Co-authored-by: Kirill Fomichev <[email protected]> * Fix init metrics (#13) Fix init metrics so we get 0 value. * Bump version (#14) * Grpc reconnect on disconnect (#15) * retry logic Signed-off-by: Wilfred Almeida <[email protected]> * refactor: retry on disconnect Signed-off-by: Wilfred Almeida <[email protected]> * debugging Signed-off-by: Wilfred Almeida <[email protected]> * mtransaction client debugging 2 Signed-off-by: Wilfred Almeida <[email protected]> * revert metrics changes Signed-off-by: Wilfred Almeida <[email protected]> * refactor(client): code cleanup Signed-off-by: Wilfred Almeida <[email protected]> * refactor(client): PR changes Signed-off-by: Wilfred Almeida <[email protected]> * Fix return value and log * Fixed reconnection message * Added some updates to log messages * Removed duplicate break --------- Signed-off-by: Wilfred Almeida <[email protected]> Co-authored-by: linuskendall <[email protected]> * Add unlimited retries (#16) * Add more retries Add unlimited retries with a delay. * Version bump * CLose metric channel if metric receiver is closed * Moved metrics closed * Update client/main.rs Co-authored-by: Kirill Fomichev <[email protected]> --------- Co-authored-by: Kirill Fomichev <[email protected]> * feat: sendTransaction aliased function (#18) Signed-off-by: Wilfred Almeida <[email protected]> * Grpc hot reload (#19) * feat: sendTransaction aliased function Signed-off-by: Wilfred Almeida <[email protected]> * feat: grpc urls file watcher Signed-off-by: Wilfred Almeida <[email protected]> * refactor: file watcher to signals Signed-off-by: Wilfred Almeida <[email protected]> * refactor: spawn management Signed-off-by: Wilfred Almeida <[email protected]> * refactor: task spawn/kill management Signed-off-by: Wilfred Almeida <[email protected]> * refactor: PR review fixes Signed-off-by: Wilfred Almeida <[email protected]> --------- Signed-off-by: Wilfred Almeida <[email protected]> * Enforce preflight (#21) * feat: sendTransaction aliased function Signed-off-by: Wilfred Almeida <[email protected]> * feat: grpc urls file watcher Signed-off-by: Wilfred Almeida <[email protected]> * refactor: file watcher to signals Signed-off-by: Wilfred Almeida <[email protected]> * refactor: spawn management Signed-off-by: Wilfred Almeida <[email protected]> * refactor: task spawn/kill management Signed-off-by: Wilfred Almeida <[email protected]> * refactor: PR review fixes Signed-off-by: Wilfred Almeida <[email protected]> * feat: enforce skipPreflight true Signed-off-by: Wilfred Almeida <[email protected]> --------- Signed-off-by: Wilfred Almeida <[email protected]> --------- Signed-off-by: Wilfred Almeida <[email protected]> Co-authored-by: Pablo Fontoura <[email protected]> Co-authored-by: Kirill Fomichev <[email protected]> Co-authored-by: Wilfred Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜What is this PR for?
Disconnect client when validator is offline and reconnect when it's back up.
🛠️What type of PR is it?
Feature
✔️Issues