You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am part way through the book and enjoying it very much. Here are the things I have noticed.
Comments on FP-OO (version G)
p27: (One or more semicolons starts a comment.
missing closing parenthesis
p23 or so: If you know Ruby, map is the same as collect.
This seems odd to me, presuming that a Ruby person knows collect first and
map in terms of collect. I'm a long-time Ruby programmer and have always used
map. I think "collect" is a Smalltalk flavour.
p29: Note: if the problems you think of...
I don't understand this paragraph.
p40: Here's a less boring method: shift
The rendering of "shift" is odd, with too much space between i and f
p49: So Clojure provides an alternate way to name sub-computations.
I suggest "alternative" instead of "alternate".
p57: I would prefer getting an exception over getting a nil.
The space between "a" and "nil" is too small. Same in following sentence.
p69: ...it passs a partial solution down the levels...
typo: 'passs'
p76: Section 6.5 "Finishing up"
the apply-message-to used here no longer has the fallback of returning an
instance variable (i.e. no automatic getter). Is this intentional? If so,
it should be mentioned.
p93: There's little of interesting remaining.
Should be interest.
p94: There you have it: a pretty functional solution to our problem.
I'd like to see a demonstration of it working.
p96: If you’d like to examine this solution in more detail, see sources/wrapped-scheduling.clj
no such file; it's (now) called scheduling-variant.clj
General comment:
why all this (def ... (fn [...] ...)) instead of (defn [...] ...) ?
p103: Here's a sequence of maps:
unexpected and unnecessary page break
p106:
another ugly page break
p107: whether it be handled with objects or not
I like a good subjenctive as much as anyone, but this reads funny to me
suggestion: remove "it be"
p110: complement would be easy enoguht for us to define:
keep this paragraph with the code that follows
p115: Exercise 2 -- your output is [false (:c :b :a) 3], but I get mil instead
of false
p117: Exercise 9 -- the calculation is supposed to be for [4 8 9 3 2], but it's
actually for [4 8 9 4 2].
p117: Implement check-sum and upc? and check it against these numbers (also in the sources):
no numbers follow the colon; the text goes straight to the next exercise
p118: In object-oriented programs, It’s not horribly unusual
unwarranted capital letter
p121: unnecessary page break
The text was updated successfully, but these errors were encountered:
p131: Inserting decider into the previous expression looks like this:
the expression (+ step2-value step1-value) is different from the previous
(+ step2-value 4)
p135: In the optional chapter on the Sequence monad, I’ll call that
the link to this optional chapter doesn't go anywhere
p138: I gave a map the metadata ‘ {:type :error} for a reason.
the quote character after the word "metadata" sticks out. Is it there in
error?
p139: For example, suppose we have this function:
It's not ideal to have a page break after this sentence and before the code.
Is there a way to mark a paragraph as "keep with next"? (That's the language
used in Microsoft Word for this feature.) I could make this comment on several
pages, but I mention it here because it seems like a no-brainer to fix, if
possible. (See p140 as well.)
Thanks for your comments. Now that I have a full-time job, work on the book (and my main open-source project, Midje) has slowed, but I hope to make a big push and get all the errata fixed soon.
I am part way through the book and enjoying it very much. Here are the things I have noticed.
Comments on FP-OO (version G)
p27: (One or more semicolons starts a comment.
p23 or so: If you know Ruby, map is the same as collect.
map in terms of collect. I'm a long-time Ruby programmer and have always used
map. I think "collect" is a Smalltalk flavour.
p29: Note: if the problems you think of...
p40: Here's a less boring method: shift
p49: So Clojure provides an alternate way to name sub-computations.
p57: I would prefer getting an exception over getting a nil.
p69: ...it passs a partial solution down the levels...
p76: Section 6.5 "Finishing up"
instance variable (i.e. no automatic getter). Is this intentional? If so,
it should be mentioned.
p93: There's little of interesting remaining.
p94: There you have it: a pretty functional solution to our problem.
p96: If you’d like to examine this solution in more detail, see sources/wrapped-scheduling.clj
General comment:
p103: Here's a sequence of maps:
p106:
p107: whether it be handled with objects or not
p110: complement would be easy enoguht for us to define:
p115: Exercise 2 -- your output is [false (:c :b :a) 3], but I get mil instead
of false
p117: Exercise 9 -- the calculation is supposed to be for [4 8 9 3 2], but it's
actually for [4 8 9 4 2].
p117: Implement check-sum and upc? and check it against these numbers (also in the sources):
p118: In object-oriented programs, It’s not horribly unusual
p121: unnecessary page break
The text was updated successfully, but these errors were encountered: