Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Python version to 3.10 TODO #201

Closed
6 tasks done
maread99 opened this issue Aug 25, 2023 · 1 comment
Closed
6 tasks done

Minimum Python version to 3.10 TODO #201

maread99 opened this issue Aug 25, 2023 · 1 comment
Labels
maintenance Keeping it all up to date

Comments

@maread99
Copy link
Owner

maread99 commented Aug 25, 2023

type annotations

  • Use of Optional and Union can now be migrated to using the | operator in the following circumstances:
    • parameter annotations of functions decorated with @valimp.parse (get_type_hints did not support the | operator prior to py 3.10). For example, Optional[Union[str, float, int]] can now be annotated as str | float | int | None.
    • creating type aliases, for example Symbols = Union[list[str], str] can now be defined as Symbols = list[str] | str
    • Indeed, search across the library for any references to Optional and Union, including with the docs, and remove / revise.
  • Should also be able to lose the from __future__ import annoations lines from the top of modules.
  • Can probably by now revert the fix implemented to accommodate bug in pandas 2.1.0 concerning treatment of origin. Intention in BUG: In 2.1.0 .resample extrapolates indexes to any 'origin' defined with Timestamp pandas-dev/pandas#55064 was to revert in 2.1.1. Required changes to revert fix are noted in comments on the commit.
@maread99 maread99 added the maintenance Keeping it all up to date label Aug 25, 2023
@maread99
Copy link
Owner Author

Would be closed by #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping it all up to date
Projects
None yet
Development

No branches or pull requests

1 participant