Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calm down dependabot #100

Open
2 of 4 tasks
maread99 opened this issue Oct 4, 2022 · 1 comment
Open
2 of 4 tasks

Calm down dependabot #100

maread99 opened this issue Oct 4, 2022 · 1 comment
Labels
CI Continuous Integration reference Includes notes useful for reference

Comments

@maread99
Copy link
Owner

maread99 commented Oct 4, 2022

Given the number and nature of dev dependencies, dependabot would raise PRs pretty much every day (if it weren't limited to 5). Merging them all would clog up the commit history (I currently ignore them and raise a single PR manually every couple of weeks or so).

I'm thinking the ideal would be:

  • Update dependencies once a fortnight, even monthly, via either
    • as presently, update manually via running the following pip-compile commands and raising a PR with the changes:
      • pip-compile --upgrade pyproject.toml
      • pip-compile --upgrade --extra=dev --output-file=requirements_dev.txt pyproject.toml (output location could change if set up dependabot for main requirements only...)
    • set up a GH workflow to automate the above, set to run once a month (see Run github cron workflow to update deps gerrymanoim/exchange_calendars#238).
  • Use dependabot ONLY for the main requirements (not the dev). Don't merge the PRs that dependabot raises (rely instead on the above) but having dependabot raise the PRs will give an immediate heads up if a dependency upgrade causes market_prices to fail (as the tests executed when the PR is raised will show as failing).
@maread99 maread99 added the CI Continuous Integration label Oct 4, 2022
maread99 added a commit that referenced this issue Oct 19, 2022
Also:
- moves `requirements_dev.txt` out of dependabots purview (#100).
maread99 added a commit that referenced this issue Oct 19, 2022
Also:
- moves `requirements_dev.txt` out of dependabots purview (#100).
@maread99 maread99 pinned this issue Oct 20, 2022
@maread99 maread99 added the reference Includes notes useful for reference label Nov 16, 2022
maread99 added a commit that referenced this issue Jul 3, 2023
Reconfigures depenadabot to look at the requriements_tests.txt file.

This is necesary in order that the triggered tests run in an environment
where the installed dependencies reflect the bumped versions! (#100).
@maread99
Copy link
Owner Author

maread99 commented Jul 3, 2023

That never worked as the tests triggered by the dependabot PRs were being executed in an environment that, necessarily, used the requirements_tests.txt file to install the dependencies, rather than the requirements.txt file that had been changed by the dependabot PR. Consequently was failing to test for compatibility with the bumped dependencies (rather tests were being run against the prior versions as defined on the requirments_test.txt).

#179 fixes by pointing dependabot at requirements_test.txt.

maread99 added a commit that referenced this issue Jul 3, 2023
Reconfigures depenadabot to look at the requriements_tests.txt file.

This is necesary in order that the triggered tests run in an environment
where the installed dependencies reflect the bumped versions! (#100).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration reference Includes notes useful for reference
Projects
None yet
Development

No branches or pull requests

1 participant