-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calm down dependabot #100
Comments
Also: - moves `requirements_dev.txt` out of dependabots purview (#100).
Also: - moves `requirements_dev.txt` out of dependabots purview (#100).
Reconfigures depenadabot to look at the requriements_tests.txt file. This is necesary in order that the triggered tests run in an environment where the installed dependencies reflect the bumped versions! (#100).
That never worked as the tests triggered by the dependabot PRs were being executed in an environment that, necessarily, used the #179 fixes by pointing dependabot at |
Reconfigures depenadabot to look at the requriements_tests.txt file. This is necesary in order that the triggered tests run in an environment where the installed dependencies reflect the bumped versions! (#100).
Given the number and nature of dev dependencies, dependabot would raise PRs pretty much every day (if it weren't limited to 5). Merging them all would clog up the commit history (I currently ignore them and raise a single PR manually every couple of weeks or so).
I'm thinking the ideal would be:
pip-compile --upgrade pyproject.toml
pip-compile --upgrade --extra=dev --output-file=requirements_dev.txt pyproject.toml
(output location could change if set up dependabot for main requirements only...)market_prices
to fail (as the tests executed when the PR is raised will show as failing).requirements.txt
in a separate directory to therequirements_dev.txt
file.Probably could just move the. EDIT - that didn't work, dependabot looks in the configured directory and all its subdirectories, i.e. under the previous arrangement, with the configured directory as the project root, dependabot could still findrequirements_dev.txt
to a sub-directory (have a look through the workflows to change the location of any of them that look at it). EDIT - Done Add ETF Mappings and update dependencies #105requirements_dev.txt
. Moverequirements.txt
#116 movesrequirements.txt
to a dedicated folder and sets dependabot to look only at that folder. The following dependabot issues cover ongoing conversations WRT making it easier to define / ignore the lock files that dependabot acts on:The text was updated successfully, but these errors were encountered: