-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use fr3 and panda #2
Draft
marcbone
wants to merge
63
commits into
master
Choose a base branch
from
refactor-to-use-fr3-and-panda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pose_motion example TODO: * make the logger compatible * get rid of code duplication * Make FR3 actually use FR3 data type * Fix warnings and lints * make other examples work * Fix documentation
marcbone
force-pushed
the
refactor-to-use-fr3-and-panda
branch
9 times, most recently
from
October 19, 2023 08:15
9e7214b
to
8eaa2a7
Compare
marcbone
force-pushed
the
refactor-to-use-fr3-and-panda
branch
from
October 19, 2023 08:24
8eaa2a7
to
03af643
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
marcbone
force-pushed
the
refactor-to-use-fr3-and-panda
branch
from
October 19, 2023 12:52
623a86f
to
7c1d5ce
Compare
marcbone
force-pushed
the
refactor-to-use-fr3-and-panda
branch
from
October 20, 2023 14:36
d66cf66
to
708b065
Compare
The Robot trait does not need a Model type anymore. Instead, it uses the RobotModel struct, which is an abstraction over the model for panda and fr3. Since currently fr3 and panda can work with the type, the RobotModel is also used internally. Should at a later point those two become incompatible, the internal model can be replaced with a type that converts into RobotModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge Pr to allow the use FR3 and Panda. They are separate structs and can be abstracted over the RobotWrapper type.
Example
The examples are already working and the usage for end-users is as I intended. However, there are still things to do:
gripper::tests::gripper_read_once
is failing on CI