Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add prettier configuration to help development #25

Open
p4535992 opened this issue May 2, 2022 · 2 comments
Open

Feature request: Add prettier configuration to help development #25

p4535992 opened this issue May 2, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@p4535992
Copy link

p4535992 commented May 2, 2022

Hi I wanted to try to develop some new features for this module and as I was hoping to do a PR in the future it would be less "brutal" for both of us if you could provide your prettier configuration.
I ask because git makes me change a lot when instead I just changed things as spaces or simply added ';' at the end of the line.

This is the most common configuration used among foundryvtt developers, but choose the one you like best.

{
    "tabWidth": 2,
    "useTabs": false,
    "singleQuote": true,
    "trailingComma": "all",
    "semi": true,
    "printWidth": 120,
    "bracketSpacing": true
}
@manuelVo
Copy link
Owner

manuelVo commented May 9, 2022

Hi there. I'm currently not using prettier at all to format my modules. If you'd like to open a PR, just make sure you follow the configuration given by the .editorconfig file (many editors do this automatically, if you have the editorconfig plugin installed). Apart from the few configurations given in there, feel free to format the code however you prefer. Just make sure the formatting isn't all over the place and don't touch lines you don't need to change for your PR, then it should be good :)

The format currently isn't exactly uniform, so you're better off not running prettier over the code at the moment, to avoid it modifying the whole repo.

Thanks in advance for whatever you have in stock!

@manuelVo
Copy link
Owner

manuelVo commented May 9, 2022

I'll keep this issue open as a request to uniformly format the code and add a prettier configuration.

@manuelVo manuelVo added the enhancement New feature or request label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants