Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub templates to simplify setup #231

Open
agitter opened this issue Jun 7, 2019 · 5 comments
Open

GitHub templates to simplify setup #231

agitter opened this issue Jun 7, 2019 · 5 comments

Comments

@agitter
Copy link
Member

agitter commented Jun 7, 2019

We can see whether GitHub templates help simplify parts of the setup process.

@dhimmel
Copy link
Member

dhimmel commented Jun 7, 2019

Okay I am briefly make this repo a template, and then create a new repository using "use this template". Then I will disable the template feature, so we can discuss how GitHub templates operates.

@dhimmel
Copy link
Member

dhimmel commented Jun 7, 2019

Okay I created https://github.com/dhimmel/rootstock-from-template. The new repo contains a single commit, dhimmel/rootstock-from-template@bc8232d, whose commit message is "Initial commit". Only the master branch was copied, not any other branch.

The effect on the GitHub repo page navigation header is nice:

image

image

Having "Template" next to the manubot/rootstock title is nice semantically to let users know that this repo is a template. Therefore, perhaps we should keep rootstock marked as template, even though this is not our recommended SETUP protocol for now?

The main issues I see with changing SETUP to use templates are:

  1. It creates additional GitHub dependency as opposed to our existing clone commands which are host-agnostic. This is only a minor issue.

  2. It squashes all commits, similar to WIP: Squash all commits cloning method #65. In many cases, this is desirable from an end-user perspective, since they want the commit history to only contain contributions specific to their manuscript. However, it makes the update process more difficult. Will be interested to see discussion that will arise on how to update repos generated from templates when those templates are changed. If we simplify rootstock in the future, such that it is more bare bones, then perhaps losing the ability to update is okay. But for now, I think this would be too much of an issue.

  3. Using templates will not simplify SETUP much because much of the complexity comes from steps other than cloning the repository.

@agitter
Copy link
Member Author

agitter commented Jun 7, 2019

Thanks for testing this. It seems like it is something to monitor but will not change our current recommendations for creating a new manuscript. Your point 3 above is critical. A user would still have to rebrand their repository and set up Travis CI after generating a new manuscript from a rootstock template.

Should we disable the template feature for now to avoid confusion about how to create a new manuscript?

@dhimmel
Copy link
Member

dhimmel commented Jun 7, 2019

Should we disable the template feature for now to avoid confusion about how to create a new manuscript?

Don't have a strong opinion but will disable.

@dhimmel
Copy link
Member

dhimmel commented Jan 8, 2020

While a template repo doesn't make sense for the current rootstock, development is underway at https://github.com/manubot/template to see if a different design using templates is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants