-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python to 3.9 #1372
Update python to 3.9 #1372
Conversation
ef8ae28
to
e3e2e20
Compare
e3e2e20
to
68ac5c2
Compare
Have you been able to create the environment on Windows? It failed for me with error:
I haven't had a look through to try and narrow down where the problem might be, but let me know if it would help for me to take a look. Everything seems good on Linux, though. |
I'd not tested on windows. I'll see if I can work out the issue. |
The clash seems to be with astra-toolbox. On windows an environment with just
We'll need to wait for a cil-astra which allows |
68ac5c2
to
42331c0
Compare
42331c0
to
f130371
Compare
19e4b81
to
4c6e911
Compare
CIL 21.4.0 and Astra 2.0 allow the all the conda packages to resolve on WIndows. Next issue is installing pyqt with pip. Looks like it is attempting to build so missing a wheel? |
fb1e35f
to
f88c6f4
Compare
During testing I spotted some new warnings, but they are due to TomographicImaging/CIL#1253 so don't need to block this PR. |
Issue
Closes #1341
Description
Update python to 3.9
No code changes needed
Testing & Acceptance Criteria
Tests should pass.
python ./setup.py create_dev_env
You might need to update the precommit hooks for the new python version:
pre-commit install
I have tested installing and running locally (linux) and IDAaaS.
Documentation
Release notes