Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to 3.9 #1372

Merged
merged 2 commits into from
May 13, 2022
Merged

Update python to 3.9 #1372

merged 2 commits into from
May 13, 2022

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Mar 14, 2022

Issue

Closes #1341

Description

Update python to 3.9

No code changes needed

Testing & Acceptance Criteria

Tests should pass.

python ./setup.py create_dev_env

You might need to update the precommit hooks for the new python version:
pre-commit install

I have tested installing and running locally (linux) and IDAaaS.

Documentation

Release notes

@rbauststfc
Copy link
Collaborator

Have you been able to create the environment on Windows? It failed for me with error:

- nothing provides openssl >=1.1.1m,<1.1.2a needed by python-3.9.10-h6cc024a_1

I haven't had a look through to try and narrow down where the problem might be, but let me know if it would help for me to take a look.

Everything seems good on Linux, though.

@samtygier-stfc
Copy link
Collaborator Author

I'd not tested on windows. I'll see if I can work out the issue.

@samtygier-stfc
Copy link
Collaborator Author

samtygier-stfc commented Mar 15, 2022

The clash seems to be with astra-toolbox. On windows an environment with just python=3.8.* and astra-toolbox=1.9.9 is fine. But with python=3.9.* and astra-toolbox=1.9.9 gives the openssl error.

python=3.9.* and astra-toolbox=2.0.0 also works.

We'll need to wait for a cil-astra which allows astra-toolbox=2.0.0

TomographicImaging/CIL-ASTRA#104

@coveralls
Copy link

coveralls commented Apr 25, 2022

Coverage Status

Coverage remained the same at 76.602% when pulling f88c6f4 on 1341-update-python into c82ef74 on main.

@samtygier-stfc
Copy link
Collaborator Author

CIL 21.4.0 and Astra 2.0 allow the all the conda packages to resolve on WIndows.

Next issue is installing pyqt with pip. Looks like it is attempting to build so missing a wheel?

@samtygier-stfc
Copy link
Collaborator Author

Updating the PyQt version fixes install but changes the spacing is several layouts. Looks like it is just removing unneeded white space, so an improvement.

image

This was referenced May 10, 2022
@samtygier-stfc
Copy link
Collaborator Author

Splitting out the CIL and Qt parts into #1449 and #1452

@samtygier-stfc
Copy link
Collaborator Author

During testing I spotted some new warnings, but they are due to TomographicImaging/CIL#1253 so don't need to block this PR.

@samtygier-stfc samtygier-stfc marked this pull request as ready for review May 12, 2022 11:28
@rbauststfc rbauststfc merged commit e2dbf9e into main May 13, 2022
@rbauststfc rbauststfc deleted the 1341-update-python branch May 13, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate newer python version
3 participants