Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with self.getExamDate Function in self.doExamCheck function #23

Open
deroskarmodulo opened this issue Feb 22, 2022 · 0 comments
Open

Comments

@deroskarmodulo
Copy link

Multiple exams with same dateOfExam are all highlighted even though they have a different nameOfExam.
Issue appears in Code the first time in the output of the self.doExamCheck function. It seems to just regard on the date, however, not on the label! I am not aware, if any issues at the registration process itself would appear.

At first sigth, in dateOfExam the examLabel variable is not really used, the output solely relys on the examDate, since in the self.getExamDate function.

Possible fix (at least if date and name are given and enabled):

    self.getExamDate = function (nameOfExam, dateOfExam) {
        return $(".groupWrapper .header_element").filter(function () {
            var examData = $(this).text().trim();
            return examData.match(nameOfExam + " " + dateOfExam);
        });
    };

Additionally, I would like to mention that the script works only if the language in TISS is set to German. It would be lovely to have that mentioned in the description anywhere.

Thanks for your time.
Hope I could help to enhance your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant