From ae430e689fc6a66c1abfd54cc6e5930141a65b97 Mon Sep 17 00:00:00 2001 From: Soufiane Fariss Date: Sat, 24 Feb 2024 19:23:14 +0100 Subject: [PATCH 1/3] [Changelog] replace deprecated IDA API find_binary with bin_binary --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e469a676b..cc520faa6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ ### capa explorer IDA Pro plugin +- replace deprecated IDA API find_binary with bin_search #1606 @s-ff ### Development From ee5a6cf9149bb3c0a0c200ce8798e47c6097dee2 Mon Sep 17 00:00:00 2001 From: Soufiane Fariss Date: Sat, 24 Feb 2024 19:35:06 +0100 Subject: [PATCH 2/3] [Changelog] replace deprecated IDA API find_binary with bin_binary --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e469a676b..cc520faa6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ ### capa explorer IDA Pro plugin +- replace deprecated IDA API find_binary with bin_search #1606 @s-ff ### Development From 79cb10e0a3ec717fc4dc6ecaa6a40874194b4e40 Mon Sep 17 00:00:00 2001 From: Soufiane Fariss Date: Sat, 24 Feb 2024 19:42:10 +0100 Subject: [PATCH 3/3] Fix indentation (code style) --- capa/features/extractors/ida/helpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/capa/features/extractors/ida/helpers.py b/capa/features/extractors/ida/helpers.py index 1abc45a58..93cfd5a83 100644 --- a/capa/features/extractors/ida/helpers.py +++ b/capa/features/extractors/ida/helpers.py @@ -34,7 +34,7 @@ def find_byte_sequence(start: int, end: int, seq: bytes) -> Iterator[int]: err = ida_bytes.parse_binpat_str(patterns, 0, seqstr, 16, encoding) if not err: - while True: + while True: ea = ida_bytes.bin_search(start, end, patterns, ida_bytes.BIN_SEARCH_FORWARD) if ea == idaapi.BADADDR: break