From bfbd4ad51ac88516cc1a98922df3df21bc36049b Mon Sep 17 00:00:00 2001 From: Mike Hunhoff Date: Fri, 16 Aug 2024 11:45:12 -0600 Subject: [PATCH] binexport: remove outdated TODOs --- capa/features/extractors/binexport2/function.py | 1 - capa/features/extractors/binexport2/insn.py | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/capa/features/extractors/binexport2/function.py b/capa/features/extractors/binexport2/function.py index 282e4b5f2..0c49036d1 100644 --- a/capa/features/extractors/binexport2/function.py +++ b/capa/features/extractors/binexport2/function.py @@ -42,7 +42,6 @@ def extract_function_loop(fh: FunctionHandle) -> Iterator[Tuple[Feature, Address edges: List[Tuple[int, int]] = [] for edge in flow_graph.edge: - # TODO (meh): use Edge.is_back_edge pending https://github.com/mandiant/capa/issues/2101 edges.append((edge.source_basic_block_index, edge.target_basic_block_index)) if loops.has_loop(edges): diff --git a/capa/features/extractors/binexport2/insn.py b/capa/features/extractors/binexport2/insn.py index eab2182f8..d83a73088 100644 --- a/capa/features/extractors/binexport2/insn.py +++ b/capa/features/extractors/binexport2/insn.py @@ -65,20 +65,6 @@ def extract_insn_api_features(fh: FunctionHandle, _bbh: BBHandle, ih: InsnHandle for name in capa.features.extractors.helpers.generate_symbols("", api_name): yield API(name), ih.address - """ - # TODO: re-enable pending https://github.com/google/binexport/issues/126#issuecomment-2074402906 - function_name = vertex.mangled_name - if vertex.HasField("library_index"): - # TODO: this seems to be incorrect for Ghidra extractor - library = be2.library[vertex.library_index] - library_name = library.name - - for name in capa.features.extractors.helpers.generate_symbols(library_name, function_name): - yield API(name), ih.address - else: - yield API(function_name), ih.address - """ - def extract_insn_number_features( fh: FunctionHandle, bbh: BBHandle, ih: InsnHandle