Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Java and Android categories #680

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Oct 6, 2023

Merge Java and Android categories into Java/Android to make it easier to find the tools.

Closes #671

@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Oct 6, 2023
@Ana06 Ana06 force-pushed the android_java branch 2 times, most recently from a59f564 to bfb13ce Compare October 6, 2023 10:33
@Ana06 Ana06 added this to the FLARE-VM 2023 Q4 milestone Oct 6, 2023
@Ana06 Ana06 added the 🌀 FLARE-VM A package or feature to be used by FLARE-VM label Oct 6, 2023
@@ -51,7 +51,7 @@ body:
description: Which category should this tool be installed to?
options:
- Active Directory
- Android
- Java/Android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Android/Java

Copy link
Member Author

@Ana06 Ana06 Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean I should order it alphabetically or change it to Android/Java. I prefer to keep Java/Android. @mr-tz do you disagree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Android/Java but yeah main nit is the alphabetical order here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Android/Java

why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal, so feel free to go ahead and merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just curious because I had it the other way around and then I changed it because I though Java is more general. I have sorted it alphabetically now..

Merge Java and Android categories into Java/Android to make it easier to
find the tools.
@Ana06 Ana06 merged commit 3f7926c into mandiant:main Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Java and Android categories into Java/Android.
2 participants