Fix internet_detector not installing #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emtuls
force-pushed
the
internet-detect-fix
branch
from
c5c58e8
to
3f0d283
Compare
emtuls
force-pushed
the
internet-detect-fix
branch
from
3f0d283
to
7644e03
Compare
emtuls
force-pushed
the
internet-detect-fix
branch
from
7644e03
to
fdeea9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1131
I believe the issue stems primarily from BoxStarter running a terminal from
system32, which PyInstaller will not run properly from. This is why it worked during testing via our test script and not when running a full install with the FlareVM install script.I also noticed that what I thought was a workaround for
cmdbeing spawned in a usermode context from an admin PowerShell was not actually doing such, so I removed the statement that said that and also forced PyInstaller to be a version that will continue to allow us to run it in an admin context.