Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Add recaf.vm #1160

Merged
merged 1 commit into from
Nov 22, 2024
Merged

🤖 Add recaf.vm #1160

merged 1 commit into from
Nov 22, 2024

Conversation

vm-packages
Copy link
Contributor

Automated PR from #1155 🚀

@vm-packages vm-packages added the 🆕 package New package request/idea/PR label Nov 7, 2024
@Ana06 Ana06 assigned Ana06 and unassigned Ana06 Nov 15, 2024
@Ana06 Ana06 self-requested a review November 15, 2024 14:40
Ana06
Ana06 requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the dependency @sara-rn, the tool works well now, but the name is incorrect, causing it to show the .jar in the shortcut and a duplication .jar.jar in the tool name. Can you please fix that? 🙏

packages/recaf.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@Ana06 Ana06 added the 🌀 FLARE-VM A package or feature to be used by FLARE-VM label Nov 15, 2024
Ana06
Ana06 reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sara-rn please squash your commits in order to keep a clean commit history. 😄

Ana06
Ana06 reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sara-rn similarly as in #1162 (review), can you please reword the commit message to explain why the change is needed without included the squashed fixup commit messages? For example:

Add recaf.vm

Add Java bytecode editor useful for RE.

@sara-rn
Copy link
Contributor

sara-rn commented Nov 22, 2024

Closes #1155

@vm-packages @sara-rn
Add recaf.vm
8926821 
Add Java bytecode editor useful for RE
Ana06
Ana06 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sara-rn! Can you please send a PR to add this package to the default FLARE-VM configuration (see an example in mandiant/flare-vm#628)? 😄

@Ana06 Ana06 merged commit 524fe75 into main Nov 22, 2024
6 checks passed
@Ana06 Ana06 mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sara-rn sara-rn sara-rn left review comments

@Ana06 Ana06 Ana06 approved these changes

Assignees

@sara-rn sara-rn

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 🆕 package New package request/idea/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vm-packages @sara-rn @Ana06