Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VM-Assert-Signature & restore hash installation for RegCool #1157

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Improve VM-Assert-Signature & restore hash installation for RegCool #1157

merged 2 commits into from
Nov 14, 2024
+22 −49

Commits on Nov 6, 2024

  1. Improve VM-Assert-Signature 

    The current implementation of `VM-Assert-Signature` uses
`Get-AuthenticodeSignature` status, that only checks that the file has a
syntactically syntactically valid signature. Verify the signing
authority using `signtool.exe`.
    @Ana06
    Ana06 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    520a3b8 View commit details
    Browse the repository at this point in the history

  2. [regcool.vm] Restore hash installation 

    The new signature verification in `CM-Assert-Signature` using
`signtool.exe` does not work for RegCool. Restore the previous
installation checking the SHA256. As the tool is using a URL that does
not include the version, the hash will change with every update,
breaking the package. If the package is updated often, we will need to
remove it from the default configuration (replacing it total-registry)
or researching if it is possible to use `signtool.exe` to verify the
package.

Note that the previous package implementation being replaced here had an
important bug: `VM-Assert-Signature` was not called at all, as
`Get-ChildItem -Path "$toolDir\*.{exe,dll}"` does not match any file.
    @Ana06
    Ana06 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ab05c62 View commit details
    Browse the repository at this point in the history