Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a custom schema #64

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Conversation

malthe
Copy link
Owner

@malthe malthe commented Mar 8, 2021

What is the current behavior?

What is the new behavior?

This fixes issue #35.

Checklist

Please make sure the following requirements are complete:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes /
    features)
  • All automated checks pass (CI/CD)

@malthe malthe marked this pull request as draft March 8, 2021 18:03
@malthe
Copy link
Owner Author

malthe commented Mar 8, 2021

@stas what do you think about this?

@stas
Copy link
Collaborator

stas commented Mar 10, 2021

@malthe it's not clear from the changeset if the interface of the API calls changed, it would be nice to have the default schema work without changing anything by the end-users. Otherwise, this looks great 🚀 🙃

@malthe malthe force-pushed the issue/35-custom-schema branch 2 times, most recently from 05d30ed to 840786a Compare March 12, 2021 17:43
@malthe malthe force-pushed the issue/35-custom-schema branch from 840786a to d7a3906 Compare March 12, 2021 18:03
@malthe malthe requested a review from stas March 12, 2021 18:10
@malthe malthe marked this pull request as ready for review March 12, 2021 18:11
@malthe
Copy link
Owner Author

malthe commented Mar 12, 2021

@stas that's been fixed now – code is simplified as well.

Copy link
Collaborator

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ❤️ 🙌

@malthe malthe merged commit faf73d3 into master Mar 16, 2021
@malthe malthe deleted the issue/35-custom-schema branch March 16, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants