Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point comparison in if-clause generates warning #429

Open
agalbachicar opened this issue Jun 9, 2021 · 1 comment
Open

Floating point comparison in if-clause generates warning #429

agalbachicar opened this issue Jun 9, 2021 · 1 comment

Comments

@agalbachicar
Copy link
Collaborator

Compilation warning:

/home/agalbachicar/maliput_ws/src/ign-gui0/src/plugins/TimePanel.cc: In member function ‘void ignition::gui::plugins::TimePanel::ProcessMsg()’:
/home/agalbachicar/maliput_ws/src/ign-gui0/src/plugins/TimePanel.cc:278:48: warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
   if (this->dataPtr->msg.real_time_factor() != 0.0)
@scpeters
Copy link
Contributor

scpeters commented Jun 9, 2021

this should be moot once we remove our dependency on ignition-gui0 as part of #423, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants