Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 1.0.0 #10

Open
gusreyes01 opened this issue May 23, 2015 · 6 comments
Open

Ionic 1.0.0 #10

gusreyes01 opened this issue May 23, 2015 · 6 comments

Comments

@gusreyes01
Copy link

Are there any plans to make this app compatible with Ionic 1.0.0 Uranium Unicorn?

@malikov
Copy link
Owner

malikov commented May 24, 2015

I'd love to do it and have been thinking about doing so for a while. However I lack the time to do it.

@gusreyes01
Copy link
Author

I'm just getting started with Ionic and your app has been really useful to handle authentication with Oauth, however I've seen some issues when upgrading the Ionic version that I cannot yet resolve. Let me know if you need any help.

@malikov
Copy link
Owner

malikov commented May 29, 2015

@gusreyes01 guess what I'll give the update to 1.0.0 a shot this week end. This should be fun. I'll update the repo once I've done so.

@gusreyes01
Copy link
Author

That's great news! I'll be aware of any updates.

I can give you a heads up on what I've found not to be working so far.

@malikov
Copy link
Owner

malikov commented Jun 1, 2015

Hey @gusreyes01,
yes indeed you have to change line 76 in /services/interceptors/http-auth-interceptor.js from

     $httpProvider.responseInterceptors.push(interceptor);

to

   $httpProvider.interceptors.push(interceptor);

since responeInterceptors was discontinued in 1.3 and up. I've done that in one of my other projects and it seems to work. Haven't had much time to finish working on this but I'll resume updating to 1.0.0 next week end. Thank you for your patience.

@gusreyes01
Copy link
Author

Yeah that works so far. Thank you for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants