-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt.ImhDigitsOnly is not handled correctly #31
Comments
Found this as I was looking into why DigitsOnly doesn't work at all using Wayland input method protocol. It seems like fixing this the right way, probably also requires breaking ABI/API. There are also other input method hints not being handled at all by Maliit currently, which would be nice to fix. |
No, the issue reported here is that DigitsOnly and FormatedNumberesOnly are being treated equally, while they should be different (DigitsOnly shouldn't have -, #, etc… symbols). #66 only fixes that DigitsOnly wasn't working at all with the wayland protocol. :) |
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
As formatted numbers and pure digits are separate content requirements and should have separate keyboard panels, provide the API to treat them separately, as they are treated in toolkits and wayland protocols. Fixes maliit#31
In MInputContext::contentType(), the following lines of code treat Qt.ImhDigitsOnly and Qt::ImhFormattedNumbersOnly the same:
This can't be correct.
The docs have the following:
ImhDigitsOnly: Only digits are allowed.
ImhFormattedNumbersOnly: Only number input is allowed. This includes decimal point and minus sign.
To correctly handle both flags, maliit needs a new contentType. Something like Maliit::DigitContentType maybe.
The text was updated successfully, but these errors were encountered: