Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twios: add proper cross compiled binary, always fetch latest ref #2122

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

BobrImperator
Copy link
Contributor

@BobrImperator BobrImperator commented Sep 21, 2023

  • Adds new properly cross-compiled binary
  • Adds a new 'twios' label and allows to run create-twios job when added/removed.
    this allows for testing the workflow.
  • Removes unnecessary volta setup, runs the binary directly instead.
  • Makes sure the latest branch changes are fetched when creating and editing post.

closes #2129

@BobrImperator BobrImperator added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Sep 21, 2023
@BobrImperator BobrImperator added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Sep 21, 2023
@BobrImperator BobrImperator added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Sep 21, 2023
@BobrImperator BobrImperator force-pushed the fix-twios-workflow branch 9 times, most recently from 590cf51 to 93cebfe Compare September 21, 2023 15:00
@BobrImperator BobrImperator added dependencies Pull requests that update a dependency file twios re-run-twios and removed dependencies Pull requests that update a dependency file labels Sep 21, 2023
@BobrImperator BobrImperator removed the twios re-run-twios label Sep 21, 2023
@BobrImperator BobrImperator added the twios re-run-twios label Sep 21, 2023
@BobrImperator BobrImperator removed the twios re-run-twios label Sep 21, 2023
@BobrImperator BobrImperator added twios re-run-twios and removed twios re-run-twios labels Sep 21, 2023
@BobrImperator BobrImperator changed the title chore(ci): fetch latest ref Twios: add proper cross compiled binary, always fetch latest ref Sep 21, 2023
@BobrImperator BobrImperator added twios re-run-twios and removed twios re-run-twios labels Sep 21, 2023
@BobrImperator BobrImperator added twios re-run-twios and removed twios re-run-twios labels Sep 21, 2023
@BobrImperator BobrImperator added twios re-run-twios and removed twios re-run-twios labels Sep 21, 2023
@marcoow
Copy link
Member

marcoow commented Sep 22, 2023

@BobrImperator
Copy link
Contributor Author

@marcoow It does work, it just attempts to read this Pull request's comment which doesn't have the info.

Here's an actual PR it would work for
#2125

@marcoow
Copy link
Member

marcoow commented Sep 22, 2023

ok but since the build for this PR fails, I'm not sure what I'm supposed to review – assume we don't want to merge with failing build?

@BobrImperator
Copy link
Contributor Author

BobrImperator commented Sep 22, 2023

@marcoow The jobs are setup to run only on twios branches, unfortunately i made the mistake of naming this one with twios word in it.

@BobrImperator
Copy link
Contributor Author

BobrImperator commented Sep 26, 2023

@marcoow see the jobs ran for a renamed PR with the same changes #2129

"create_twios" and "edit_twios" jobs fail here only because they're not meant to be ran here.
In a real scenario "create_twios" would only run on automated, scheduled trigger or workflow_dispatch while the "create-twios" solution is only for testing new program versions.

Also the edit_twios job works correctly here: #2125

@BobrImperator BobrImperator merged commit 5feb8f3 into master Sep 26, 2023
14 of 15 checks passed
@BobrImperator BobrImperator deleted the fix-twios-workflow branch September 26, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants