-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Trash in, Treasure out' blog post #2573
Conversation
I don't know what's going on with CI, but it doesn't seem like the failing jobs are caused by this addition? |
about Mermaid, you can ask @umbrellas – I guess there should be a plugin or so for 11ty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great post! Let's get it out asap. @IdeliaRisella can handle things like adding og:image
, scheduling the release, etc.
If we can't figure out a solution for supporting Mermaid diagrams easily, let's just use an image instead for now.
I replaced the mermaid source with a rendered SVG, and did some other fixes. I added the metadata as suggested by @BobrImperator, but CI still seems to be failing. I'm gonna need some help with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdoordt you need to add your author profile image (named hdoordt.jpg
) in https://github.com/mainmatter/mainmatter.com/tree/master/static/assets/images/authors
312d040
to
f7c5e13
Compare
a1fbe4e
to
54f57ac
Compare
54f57ac
to
510691a
Compare
@marcoow Most of the checks seem to pass right now. The 'Craw links' check seems to fail on some image that's not related to this PR not being there, and the others need manual interaction. I looked at the preview and it looks good now to me |
Companion repo: https://github.com/mainmatter/trash-in-treasure-out/
Todo: