Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Trash in, Treasure out' blog post #2573

Merged
merged 13 commits into from
Dec 6, 2024
Merged

Conversation

hdoordt
Copy link
Member

@hdoordt hdoordt commented Dec 2, 2024

Companion repo: https://github.com/mainmatter/trash-in-treasure-out/

Todo:

  • add links to steps
  • Add short explanation of title (parody on 'garbage in, garbage out')
  • Do something about the mermaid diagram. Support for that on the site would be cool. @marcoow any ideas?

@hdoordt
Copy link
Member Author

hdoordt commented Dec 2, 2024

I don't know what's going on with CI, but it doesn't seem like the failing jobs are caused by this addition?

@marcoow
Copy link
Member

marcoow commented Dec 3, 2024

about Mermaid, you can ask @umbrellas – I guess there should be a plugin or so for 11ty

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great post! Let's get it out asap. @IdeliaRisella can handle things like adding og:image, scheduling the release, etc.

If we can't figure out a solution for supporting Mermaid diagrams easily, let's just use an image instead for now.

src/posts/2024-12-02-trash-in-treasure-out.md Outdated Show resolved Hide resolved
src/posts/2024-12-02-trash-in-treasure-out.md Outdated Show resolved Hide resolved
src/posts/2024-12-02-trash-in-treasure-out.md Outdated Show resolved Hide resolved
src/posts/2024-12-02-trash-in-treasure-out.md Outdated Show resolved Hide resolved
@IdeliaRisella
Copy link
Contributor

@marcoow I have already sent the og:image to @hdoordt yesterday, let me know if you need anymore help. Meanwhile, I can help prepare the publication on social media on Friday.

@hdoordt
Copy link
Member Author

hdoordt commented Dec 6, 2024

I replaced the mermaid source with a rendered SVG, and did some other fixes.

I added the metadata as suggested by @BobrImperator, but CI still seems to be failing. I'm gonna need some help with this.

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdoordt you need to add your author profile image (named hdoordt.jpg) in https://github.com/mainmatter/mainmatter.com/tree/master/static/assets/images/authors

src/posts/2024-12-02-trash-in-treasure-out.md Show resolved Hide resolved
@hdoordt hdoordt force-pushed the trash-in-treasure-out branch from 312d040 to f7c5e13 Compare December 6, 2024 10:56
@hdoordt hdoordt requested a review from marcoow December 6, 2024 11:07
@hdoordt hdoordt force-pushed the trash-in-treasure-out branch from a1fbe4e to 54f57ac Compare December 6, 2024 11:12
@hdoordt hdoordt force-pushed the trash-in-treasure-out branch from 54f57ac to 510691a Compare December 6, 2024 11:17
@hdoordt
Copy link
Member Author

hdoordt commented Dec 6, 2024

@marcoow Most of the checks seem to pass right now. The 'Craw links' check seems to fail on some image that's not related to this PR not being there, and the others need manual interaction.

I looked at the preview and it looks good now to me

@hdoordt hdoordt merged commit 5fce0cb into master Dec 6, 2024
18 of 19 checks passed
@hdoordt hdoordt deleted the trash-in-treasure-out branch December 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants