Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add newsletter-signup id for signup form #2443

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: add newsletter-signup id for signup form #2443

merged 1 commit into from
Jun 12, 2024

Conversation

BobrImperator
Copy link
Contributor

@BobrImperator BobrImperator commented Jun 11, 2024 •
edited
Loading

  • Adds an id=newsletter-signup attribute to the cta-banner form.

image

@BobrImperator BobrImperator force-pushed the add-id-for-newsletter branch from 40bea79 to 0b2bd69 Compare June 11, 2024 09:47
@BobrImperator BobrImperator enabled auto-merge June 11, 2024 09:48
@emmasofiah2o emmasofiah2o requested a review from marcoow June 11, 2024 11:15
marcoow
marcoow reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this for all the newsletters?

@BobrImperator
Copy link
Contributor Author

BobrImperator commented Jun 11, 2024 •
edited
Loading

This adds an id to the sing up form in cta-banner component.
Does this not cover all newsletter sign up forms?

It seems to be working fine for the main page, svelte consulting and rust consulting pages.

marcoow
marcoow approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, misread this

@BobrImperator BobrImperator merged commit 1ed43c0 into master Jun 12, 2024
17 of 18 checks passed
@BobrImperator BobrImperator deleted the add-id-for-newsletter branch June 12, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobrImperator @marcoow