-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content changes to ember landing page #2219
Conversation
moved over comment from previous PR: @yaigrie I filled in the content. There's some TODOs left open I think:
Could you make those changes and then review everything again (there might be links missing etc.) and finalize this? Chris, Sarah, and myself should then do a final review before merging |
@marcoow do we want Chris to be the (sole) ember expert? And do we need the appointment link, if he's the expert? He would like to discuss that first, if that's the case. |
So we need people that are known in the community. Chris is the best known among the team but if he doesn't want to do it alone, we could also add Nick and myself. |
@yaigrie I added ember-promise-modals to the list of open source projects but it's missing a logo |
@yaigrie can you take this over so we can get it merged? |
@marcoow I added a small hand for the promise modals |
is Chris not doing this? |
@yaigrie let's maybe just add Chris', Nick's, and my photo instead of Chris alone – I think some faces that are familiar to people doing Ember will be helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some text fixses
This reverts commit 62aa591.
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
Co-authored-by: Marco Otte-Witte <[email protected]>
This reverts commit 537ad96.
…tter/mainmatter.com into update-ember-landing-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content isn't done yet, so it's not ready to merge :)
This is a copy of the PR #2166 by @yaigrie. It was closed by accident and could not be reopened.