Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content changes to ember landing page #2219

Closed
wants to merge 41 commits into from
Closed

Conversation

lolmaus
Copy link
Collaborator

@lolmaus lolmaus commented Nov 15, 2023

content isn't done yet, so it's not ready to merge :)


This is a copy of the PR #2166 by @yaigrie. It was closed by accident and could not be reopened.

@marcoow
Copy link
Member

marcoow commented Nov 16, 2023

moved over comment from previous PR:

@yaigrie I filled in the content. There's some TODOs left open I think:

  • get a higher resolution photo of Chris
  • fix the calendly link for booking a call with Chris
  • the EmberFest logo looks a bit strange/small – I think there's a max width and I guess if we use the 2-line version we currently have on emberfest.eu it should look better

Could you make those changes and then review everything again (there might be links missing etc.) and finalize this? Chris, Sarah, and myself should then do a final review before merging

@yaigrie
Copy link
Contributor

yaigrie commented Nov 16, 2023

@marcoow do we want Chris to be the (sole) ember expert? And do we need the appointment link, if he's the expert? He would like to discuss that first, if that's the case.
Or do we want to have a shared calendar for multiple ember experts? I think I might have just put Chris as the expert while creating the template site because I thought he was THE ember expert 🤔

@marcoow
Copy link
Member

marcoow commented Nov 17, 2023

So we need people that are known in the community. Chris is the best known among the team but if he doesn't want to do it alone, we could also add Nick and myself.

@marcoow
Copy link
Member

marcoow commented Nov 20, 2023

@yaigrie I added ember-promise-modals to the list of open source projects but it's missing a logo

@marcoow
Copy link
Member

marcoow commented Dec 11, 2023

@yaigrie can you take this over so we can get it merged?

@yaigrie
Copy link
Contributor

yaigrie commented Dec 21, 2023

@marcoow I added a small hand for the promise modals
ember-promise-modals
and removed chris for now - I guess with 3 names its link will still just lead to the contact page? As I think a shared calendar for you guys seems like a bit of a hassle?

@yaigrie yaigrie requested a review from marcoow December 21, 2023 12:40
@marcoow
Copy link
Member

marcoow commented Dec 21, 2023

is Chris not doing this?

@marcoow
Copy link
Member

marcoow commented Dec 22, 2023

@yaigrie let's maybe just add Chris', Nick's, and my photo instead of Chris alone – I think some faces that are familiar to people doing Ember will be helpful

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some text fixses

src/ember-consulting.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
src/components/content/secondary-feature-emberfest.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
src/ember-consulting.njk Outdated Show resolved Hide resolved
@yaigrie yaigrie requested a review from marcoow January 8, 2024 15:05
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

It just looks a bit weird that the 2 side boxes have different widths. Should they not be equal?

Bildschirmfoto 2024-01-08 um 17 48 49

@yaigrie yaigrie closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants