Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Declaration count threshold #16

Open
torokati44 opened this issue Apr 3, 2024 · 1 comment
Open

Feature Idea: Declaration count threshold #16

torokati44 opened this issue Apr 3, 2024 · 1 comment

Comments

@torokati44
Copy link

First of all, thanks for this tool, it's really promising!

I recently ran it on Ruffle, and found that it moved dozens of dependency entries to the workspace Cargo.toml.
Which is fine, it's what it says on the tin, after all...

But I don't want to do that - instead, I'd like to make only those dependencies workspace-level ones that are declared in at least 2 or 3 different crates.

Do you think this is something you'd be willing to add as a feature? 😊

@LukeMathWalker
Copy link
Collaborator

Yes, the current philosophy is "move everything to [workspace.dependencies]. We could consider a threshold, but I'd like to have #2 before adding it. That'd allow you to enforce that the threshold is consistently met in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants