Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation message does not specify which field is not passing validation #106

Open
1 task done
MaxwellGarceau opened this issue Jan 2, 2025 · 0 comments
Open
1 task done
Labels
type:enhancement New feature or request.
Milestone

Comments

@MaxwellGarceau
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

On form submission, wen entering invalid address information, a user has no idea which address field is invalid if one of the fields does not pass validation.

Reproduce

  1. Require address in the test user Mailchimp account
  2. Leave either city or address line 1 empty
  3. You will receive a generic error message that the address fails validation
generic-error-message-when-address-validation-fails.mov

Designs

The solution would be to customize the validation message based on which field failed validation. I suspect that we could take a look at what the API is sending back and see if we can get any additional information from the response. Then, we could add better conditional error reporting.

Describe alternatives you've considered

  • This could be left as is
  • A more generic error message could be left letting a user know that one of the address fields was invalid - "Address: One of the fields contains an invalid value"

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxwellGarceau MaxwellGarceau added type:enhancement New feature or request. validation and removed validation labels Jan 2, 2025
@jeffpaul jeffpaul added this to the 1.8.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants