Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non visible merge fields in a Mailchimp account will still display in the WP Mailchimp settings menu under the "Include?" column #105

Open
1 task done
MaxwellGarceau opened this issue Jan 2, 2025 · 1 comment · May be fixed by #110
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@MaxwellGarceau
Copy link
Collaborator

Describe the bug

In the WP Mailchimp settings, it's still possible to "include" a merge field that is has it's "visible" property unchecked in a Mailchimp account.

Note: The non visible merge fields will not display in the block editor or the front end

Solution

Replace the checkbox with "Not visible" text to inform the user that they must change the option in their account.

If we wanted to go the extra mile we could see if we could generate a link to that users merge fields settings edit page in their Mailchimp account.

Steps to Reproduce

  1. Uncheck the "Visible?" column in all merge fields in the test user Mailchimp account
  2. On the Mailchimp WP settings page click "Update List" to refresh the data from Mailchimp
  3. In the "Merge Fields Included" section, you will see it's still possible to include merge fields that are not visible
  4. You can include all the merge fields, navigate to the front end, and see that the merge fields do not display.

Screenshots, screen recording, code snippet

non-visible-merge-fields-can-still-be-set-in-the-mailchimp-wp-admin.mov

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxwellGarceau
Copy link
Collaborator Author

Fixed bug by adding a conditional check for only public fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
2 participants