Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove developer tools options on My Sites, Bookmarks or History pages #999

Open
calumcraig opened this issue Sep 26, 2019 · 3 comments
Open
Labels

Comments

@calumcraig
Copy link

calumcraig commented Sep 26, 2019

Testing 0.15.0-RC6 on Ubuntu 18.04.3

"Toggle developer tools" option doesn't do anything on the following:

  • My sites
  • History
  • Bookmarks

Neither menu option nor keyboard shortcut works.

@calumcraig calumcraig added the bug label Sep 26, 2019
@calumcraig calumcraig changed the title Linux - toggle developer tools doesn't work on My Sites, Bookmarks or History pages Toggle developer tools doesn't work on My Sites, Bookmarks or History pages Sep 26, 2019
@calumcraig
Copy link
Author

Also confirmed the same behaviour on RC5 on macOS.

@b-zee
Copy link

b-zee commented Sep 26, 2019

Can also confirm. I tried this Monday on the 0.15.0 release.

@joshuef
Copy link
Collaborator

joshuef commented Oct 2, 2019

So, these pages look like tabs... but they are not actually tabs. They are another part of the browser UI just now. So this isn't so much a bug, as the fact that those menu options should not be shown here (as things stand).

They could be made to be pages, simply served by the browser, eg, though this will complicate certain functionalities. Perhaps needlessly...

That's an open Q I'd say (and not something we'll likely look at in the near term). I'd say this issue should be resolved by:

  • Remove Developer Tools Toggles from context menu for internal react pages.

@joshuef joshuef changed the title Toggle developer tools doesn't work on My Sites, Bookmarks or History pages Remove developer tools options on My Sites, Bookmarks or History pages Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants