Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional security tests #1227

Open
S-Coyle opened this issue Mar 18, 2020 · 0 comments
Open

Additional security tests #1227

S-Coyle opened this issue Mar 18, 2020 · 0 comments
Labels
security Pull requests that address a security vulnerability

Comments

@S-Coyle
Copy link
Contributor

S-Coyle commented Mar 18, 2020

Specifically thinking about additional security checks to ensure we are locking down Electron as we should be.

There is what seems to be a useful Electron checklist of security recommendations here.
It seems we should verify that we are following these recommendations, and where applicable, add tests to confirm that these recommendations are effective and do not regress.

Other specific acceptance criteria that we must test to ensure we meet:

  1. Nothing is written to the file system when no write permissions have been granted.
  2. Ensure no network requests are sent out when not authorised.
@S-Coyle S-Coyle added the security Pull requests that address a security vulnerability label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

No branches or pull requests

1 participant