Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scenarios to scenario_config #736

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Oct 24, 2024

🐦 Description of this PR 🐦

  • config added SSP1-POP-GDP SSP2-POP-GDP and SSP5-POP-GDP

Scenarios for setting population and GDP to a specific SSP.
These sceanrios are needed for ScenarioMIP (VL scenario), where SDP-MC is combined with SSP1-POP-GDP SSP2-POP-GDP and SSP5-POP-GDP

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

@flohump flohump added Minor Smaller modifications Low risk Low risk labels Oct 24, 2024
@flohump flohump changed the title added SSP1-MC, SSP2-MC and SSP5-MC to scenario_config added SSP1-POP-GDP SSP2-POP-GDP and SSP5-POP-GDP Oct 24, 2024
@flohump flohump changed the title added SSP1-POP-GDP SSP2-POP-GDP and SSP5-POP-GDP added scenarios to scenario_config Oct 24, 2024
Copy link
Member

@FelicitasBeier FelicitasBeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me.

Just one question: should this be something that is included in the main scenario_config.csv or would it be better to have a ScenarioMip project config. I see arguments for both. Just asking.

@flohump
Copy link
Contributor Author

flohump commented Oct 25, 2024

Fine for me.

Just one question: should this be something that is included in the main scenario_config.csv or would it be better to have a ScenarioMip project config. I see arguments for both. Just asking.

Since these are generic pop/gdp settings, it's fine to have them in the main scenario_config.csv.
If it would be full scearios only used for SceanrioMIP, then they should be put in a seperate file. But that is no the case here.

@flohump flohump merged commit 7db3bc3 into magpiemodel:develop Oct 25, 2024
1 check passed
@flohump flohump deleted the f_updateInput branch November 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low risk Low risk Minor Smaller modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants