-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to skip particular file #407
Comments
It looks like the PHP requirements in that package are too open. For example, they claim to support PHP 8.4 and 8.9 (neither of which have been released): https://github.com/doctrine/mongodb-odm/blob/2.5.2/composer.json#L24. Getting that fixed should solve this particular problem going forward, as Composer will refuse to install packages which are not compatible with the running (or configured) PHP version. It seems that you have already reported this problem upstream in doctrine/mongodb-odm#2539. I think the work-around is to use a supported PHP version (which may take some experimentation given the broad claim in their |
thank you @fredden, but still is it very hard to provide some configuration option similar to |
What we could do is drop eager scanning of all vendors, relying on the
autoloader only: tricky, but possibly necessary for these conditional logic
blocks.
As for MongoDB ODM: are you 100% sure that you have a version installed
that is compatible with your PHP version?
Marco Pivetta
***@***.***
https://ocramius.github.io/
…On Mon, 26 Jun 2023 at 23:03, Bogdan Dubyk ***@***.***> wrote:
thank you @fredden <https://github.com/fredden>, but still is it very
hard to provide some configuration option similar to symbol-whitelist
where files that should be skipped can be lister? I'm not asking to
introduce this feature right away but can imagine more cases like mine, and
it's nice to have the option to ignore some file/path. Something similar
implemented by unused checker
https://github.com/composer-unused/composer-unused#exclude-folders-and-packages
—
Reply to this email directly, view it on GitHub
<#407 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEAGY4YMGAU5LHSXFGTXNH2I7ANCNFSM6AAAAAAZUTY3VQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
The class that this project is complaining about is deprecated and exists solely for BC reasons: https://github.com/doctrine/mongodb-odm/blob/69e64e7eb51f07bcfc09bc8e7ea8329f301b44ff/lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php#L11-L14. Said class is not used from within the ODM and the project works perfectly fine with PHP 8.2 |
yes, I'm on the latest stable version which supports PHP 8.2, all works perfectly, only CI failing because the checker analyzing this deprecated file and failing. |
My very simplistic endorsement here would be to make something as simple as Assuming you don't actually need that file, it's probably best to even drop it from your final build artifact that goes to production, to avoid anything ever touching it :) |
I have an issue with doctrine-ODM, particularly with this file https://github.com/doctrine/mongodb-odm/blob/2.6.x/lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php , checker failing with an error:
and it's because I'm using PHP 8.2 where
match
is a reserved word, I tried adding a file to a white list like thisbut not sure if I'm doing it correctly or if it's possible at all, but anyway issue is still there. Is there a way to handle this? In general this file is deprecated and my app is working only checker failing
The text was updated successfully, but these errors were encountered: