cl-generic-ensure-function: forge-topic-mark-read is already defined as something else than a generic function Mark set

[hexmode]

forge: git tag v0.4.6
transient: installed from package-install
emacs: compiled from master today and removed included transient (before I tried installing with package-install)

It looks like the time has come to update emacs' embedded transient with the copy from the transient repo.

I compiled emacs today (its been a week plus since I last did) and forge wouldn't work giving errors similar to #706. In the past I was able to fix the errors just by copying over transient.el from github and replacing the copy in my emacs checkout, but that didn't work today.

Only after I removed all the autoload references in lisp/emacs-lisp/loaddefs-gen.el and installed transient from package-install did it work.

[tarsius]

Only after I removed all the autoload references in lisp/emacs-lisp/loaddefs-gen.el and installed transient from package-install did it work.

I think the problem is that previously you skipped installing transient properly. You have to make sure that the separately installed transient is earlier on the load-path and that the transient-autoloads.el for it is generated and loaded. If you fail to do that then the built-in library and/or built-in autoload file is loaded. If a entry in the built-in autoload file is triggered, then that causes the built-in transient to be loaded.

I don't think you have to strip lisp/emacs-lisp/loaddefs-gen.el as long as you make sure that the autoload file for the separately installed transient is loaded later. Using package takes care of that. If you don't want to use package, then you have to arrange for that to happen some other way.

It looks like the time has come to update emacs' embedded transient with the copy from the transient repo.

Well I agree with that and will try to get that done today. But note that eventually this will go out of since again and I recommend you move away from "copy from the transient repo" and instead start installing it properly.

[hexmode]

My default package installation method is use-package + :vc, but this does not override the built-in version for transient (or other packages).

Since use-package wasn't working, I started mucking around and it wasn't until I had mucked too much that I thought of using package-install.

This is probably an emacs bug but, the following command sequence does not check out transient into ~/.emacs.d/elpa:

rm -rf ~/.emacs.d && echo '(use-package transient    
  :vc (:url "https://github.com/magit/transient") :ensure t)' >.emacs && emacs

Whereas a similar line for magit does check out magit.

Until that problem is fixed, though, I'll use package-install for transient.

[tarsius]

Ah, most likely this is yet another instance of this awful default making our lives harder: (defcustom package-install-upgrade-built-in nil ...). This instructs package.el refuse to disrespect minimal version specified in a dependency declaration. Because minimal versions are specified for a reason, this of course causes breakage. The emacs maintainers have been informed about this, but for now they think the user should have to explicitly opt-in to non-broken dependencies. So I have to tell users one by one to set this to t.

[hexmode]

Thanks for the info, but that didn't help. :(

rm -rf ~/.emacs.d &&
echo '(setq package-install-upgrade-built-in t)
(use-package transient :vc (:url "https://github.com/magit/transient" :rev :newest) :ensure t)' > ~/.emacs &&
~/bin/emacs

My ~/.emacs.d/elpa does not contain transient after that.

Nevertheless, I see that you've upgraded the bundled transient, so I am saved some headache.

Thank you!

[hexmode]

The issue for use-package is here: https://debbugs.gnu.org/75328