Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classname Readonly throws an error (tested with PHP 8.1) #3

Open
timo42 opened this issue Oct 18, 2022 · 1 comment
Open

classname Readonly throws an error (tested with PHP 8.1) #3

timo42 opened this issue Oct 18, 2022 · 1 comment

Comments

@timo42
Copy link

timo42 commented Oct 18, 2022 •
edited
Loading

the compilation aborts with an error:
syntax error, unexpected token "readonly", expecting identifier

Class Name can not be "ReadOnly" here (Ui/DataProvider/Product/Form/Modifier/ReadOnly.php)

If you change the class name to "ReadOnly2" for example and also change the class name in the di.xml (etc/adminhtml/), the compilation process works fine.
@diwipl
Copy link
Contributor

diwipl commented Oct 18, 2022

Hi
We're working on compatibility with PHP 8 and Magento 2.4.5 internally, the above issue is already fixed internally and will be released when after we ensure MageSuite compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diwipl @timo42