You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found some strange and non-used code in EnterEventType:
EnterEventType.SELF -> EventType.ENTERS_THE_BATTLEFIELD_SELF - only Bestow ability used it
EnterEventType.CONTROL -> EventType.ENTERS_THE_BATTLEFIELD_CONTROL - never used
EnterEventType.COPY -> EventType.ENTERS_THE_BATTLEFIELD_COPY - never used
EnterEventType.OTHER -> EventType.ENTERS_THE_BATTLEFIELD -- all around
That's enters logic was introduced for multiple [[Metallic Mimic]] bug in #2765 to support self-replacement effects from rules 616.1a:
616.1a
If any of the replacement and/or prevention effects are self-replacement effects (see rule 614.15), one of them must be chosen. If not, proceed to rule 616.1b.
614.15
Some replacement effects are not continuous effects. Rather, they are an effect of a resolving spell or ability that replace part or all of that spell or ability’s own effect(s). Such effects are called self-replacement effects. The text creating a self-replacement effect is usually part of the ability whose effect is being replaced, but the text can be a separate ability, particularly when preceded by an ability word. When applying replacement effects to an event, self-replacement effects are applied before other replacement effects.
If you replace self-event by EventType.ENTERS_THE_BATTLEFIELD in Bestow then no failed tests found, so it's useless?
Current problems:
Looks like self-replacement effects are not fully supported in all cards -- it works as normal effects in current version (e.g. user will see choose dialog). Potential bug from Riot ability due miss self-replacement logic: Riot and Creature spells entering as non-creatures - bug #6413
Control modification effects not fully supported? No code usage for EnterEventType.CONTROL or EventType.ENTERS_THE_BATTLEFIELD_CONTROL:
616.1b
If any of the replacement and/or prevention effects would modify under whose control an object would enter the battlefield, one of them must be chosen. If not, proceed to rule 616.1c.
Copy replacement effects not fully supported? No code usage for EnterEventType.COPY or EventType.COPY:
616.1c
If any of the replacement and/or prevention effects would cause an object to become a copy of another object as it enters the battlefield, one of them must be chosen. If not, proceed to rule 616.1d.
It's also interesting note for "616. Interaction of Replacement and/or Prevention Effects" -- if you look above to 616.1b and 616.1c then can see the diff order from continues effects (layers logic):
Continues must use copy first (layer 1), then control (layer 2);
Replacement must use control effect first (616.1b), then copy (616.1c);
Need research of EnterEventType and 616 rules support. Is it easy to implement in all related cards (use diff ENTERS_THE_BATTLEFIELD events due effect's logic - self, copy, control or other -- ~300 cards/abilities)? I think on good implementation it can fix many reported "blood moon" problems.
The text was updated successfully, but these errors were encountered:
{2}
Artifact Creature — Shapeshifter
2/1
As Metallic Mimic enters, choose a creature type.
Metallic Mimic is the chosen type in addition to its other types.
Each other creature you control of the chosen type enters with an additional +1/+1 counter on it.
Enchantment Land — Urza's Saga
(As this Saga enters and after your draw step, add a lore counter. Sacrifice after III.)
I — Urza's Saga gains "{T}: Add {C}."
II — Urza's Saga gains "{2}, {T}: Create a 0/0 colorless Construct artifact creature token with 'This creature gets +1/+1 for each artifact you control.'"
III — Search your library for an artifact card with mana cost {0} or {1}, put it onto the battlefield, then shuffle.
Land — Cave
You may have Echoing Deeps enter tapped as a copy of any land card in a graveyard, except it's a Cave in addition to its other types.
{T}: Add {C}.
Found some strange and non-used code in
EnterEventType
:EnterEventType.SELF
->EventType.ENTERS_THE_BATTLEFIELD_SELF
- only Bestow ability used itEnterEventType.CONTROL
->EventType.ENTERS_THE_BATTLEFIELD_CONTROL
- never usedEnterEventType.COPY
->EventType.ENTERS_THE_BATTLEFIELD_COPY
- never usedEnterEventType.OTHER
->EventType.ENTERS_THE_BATTLEFIELD
-- all aroundThat's enters logic was introduced for multiple [[Metallic Mimic]] bug in #2765 to support self-replacement effects from rules 616.1a:
If you replace self-event by
EventType.ENTERS_THE_BATTLEFIELD
in Bestow then no failed tests found, so it's useless?Current problems:
EnterEventType.CONTROL
orEventType.ENTERS_THE_BATTLEFIELD_CONTROL
:EnterEventType.COPY
orEventType.COPY
:TODO:
EnterEventType
and 616 rules support. Is it easy to implement in all related cards (use diff ENTERS_THE_BATTLEFIELD events due effect's logic - self, copy, control or other -- ~300 cards/abilities)? I think on good implementation it can fix many reported "blood moon" problems.The text was updated successfully, but these errors were encountered: