Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default backlog size and make configurable #8

Open
pietermees opened this issue Mar 18, 2018 · 2 comments · May be fixed by #12
Open

Change default backlog size and make configurable #8

pietermees opened this issue Mar 18, 2018 · 2 comments · May be fixed by #12

Comments

@pietermees
Copy link
Contributor

Sending a lot of simultaneous requests causes the backlog to overflow and new connection attempts to be rejected. (see mafintosh/turbo-http#12)

This is caused by the fixed default backlog size of 5 athttps://github.com/mafintosh/turbo-net/blob/master/src/turbo_net.c#L190.

Node's default is 511 (see https://nodejs.org/dist/latest-v9.x/docs/api/net.html#net_server_listen)
Node's listen also accepts a parameter to override the backlog size.
pietermees added a commit to pietermees/turbo-net that referenced this issue Mar 18, 2018
@pietermees
Set default backlog size to 511
912d0b1 
Match Node's default backlog of 511 sockets (see https://nodejs.org/dist/latest-v9.x/docs/api/net.html#net_server_listen)
This helps address mafintosh#8 and mafintosh/turbo-http#12
@pietermees pietermees mentioned this issue Mar 18, 2018
Merged
mafintosh pushed a commit that referenced this issue Mar 18, 2018
@pietermees @mafintosh
Set default backlog size to 511 (#9)
fd0d05b 
Match Node's default backlog of 511 sockets (see https://nodejs.org/dist/latest-v9.x/docs/api/net.html#net_server_listen)
This helps address #8 and mafintosh/turbo-http#12
@mafintosh
Copy link
Owner

It's 511 now (you've fixed that :)) - we should still make it configurable

@pietermees
Copy link
Contributor Author

Yes, and I guess we could change that TODO in the code from researching to making it configurable? Then users that don't like the default can do their own research ;)

@tuananh tuananh linked a pull request Mar 20, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make backlog size an argument for .listen() tuananh/turbo-net
2 participants
@mafintosh @pietermees