Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #78

Open
4 tasks
dargmuesli opened this issue Oct 13, 2024 · 0 comments
Open
4 tasks

chore: cleanup #78

dargmuesli opened this issue Oct 13, 2024 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest Recommendation for work that qualifies for hacktoberfest approvals refactor Changes that do not affect any result technical Not a feature nor a bug

Comments

@dargmuesli
Copy link
Member

dargmuesli commented Oct 13, 2024

The following ideas for changes in the overall code base came up:

  • use TIMESTAMPTZ, not just TIMESTAMP
  • use standardized CURRENT_TIMESTAMP, not the postgres specific NOW(), see fix(timestamp): change column type timestamp to timestamptz #67
  • extract the NULLIF(current_setting('jwt.claims.account_id', true), '')::UUID IS NOT NULL AND... occurrences into a separate function
  • use created_at, not just created

As usual, those changes would be breaking with the current deployment style of migrations, so all changes should be released together to keep maintenance work minimal.

cc @sthelemann

@dargmuesli dargmuesli added good first issue Good for newcomers hacktoberfest Recommendation for work that qualifies for hacktoberfest approvals refactor Changes that do not affect any result technical Not a feature nor a bug labels Oct 13, 2024
@dargmuesli dargmuesli moved this to 🔖 Ready in maevsi Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Recommendation for work that qualifies for hacktoberfest approvals refactor Changes that do not affect any result technical Not a feature nor a bug
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant