Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the vertical text languages outside of imagetranslation file #12

Open
maeriil opened this issue Oct 15, 2023 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@maeriil
Copy link
Owner

maeriil commented Oct 15, 2023

Currently we have a variable called vertical_langauge that contains the following contents

vertical_langauges = [
    "japanese",
    "mandarin",
]

This is used so that when the source language is one of these languages, we will need to rotate the image to better detect the texts.

def is_lang_vertical_lang(lang: str) -> bool:
    return lang in vertical_langauges

However, we shouldn't be setting this in our current file, imagetranslation.py. We need to create a seperate file and add these logics into it. The location of this file is open for discussion.

@maeriil maeriil added bug Something isn't working enhancement New feature or request labels Oct 15, 2023
@maeriil maeriil added this to the Backend API Release milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant